This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the Nomad task launcher plugin previously set the "command" field for launching tasks. Before pipelines, this was fine for ODRs. However, pipelines pass a slice of string to the
TaskLaunchInfo
struct (from the Waypoint plugin SDK) for the Entrypoint field. The Nomad Docker driver's command field accepts only string, not slice of string. Therefore, any exec steps for pipelines run by Nomad ODRs would fail to start before this PR.The entrypoint field of the Nomad Docker driver config does accept a slice of string, and that is the config now being set in the Nomad task launcher plugin.